Update ECW Dynamic driver to build with ECW SDK version 6.0 or higher #11593
Conversation
Update ECW Dynamic driver to work with ECW SDK version 6.0 or higher
psharma-gdal
changed the title
frmts/ecw/ecwdataset.cpp
Outdated
| @@ -2262,7 +2262,7 @@ CPLErr ECWDataset::IRasterIO(GDALRWFlag eRWFlag, int nXOff, int nYOff, | |||
| { | |||
| // This is tricky, because it expects the rest of the image | |||
| // with this buffer width to be read. The preferred way to | |||
| // achieve this behavior would be to call AdviseRead before | |||
| // achieve this behaviour would be to call AdviseRead before | |||
| // call IRasterIO. The logic could be improved to detect | |||
There was a problem hiding this comment.
I believe that we have chosen to use American English.
| pszOpt = CPLGetConfigOption("ECW_RESILIENT_DECODING", nullptr); | ||
| if (pszOpt) | ||
| NCSecwSetConfig(NCSCFG_RESILIENT_DECODING, | ||
| (BOOLEAN)CPLTestBool(pszOpt)); |
There was a problem hiding this comment.
Is everything still good if 60<ECWSDK_VERSION>=40?
There was a problem hiding this comment.
Yes. And the new code changes are going to support ECWSDK_VERSION>=60 as well.
@psharma-gdal Can you provide a URL where to download this SDK ? |
@rouault - ECW SDK version 6.0 or higher isn't publicly available. The ECW SDK version 6.1 should be available in couple of months. We will let you know once its available. |
|
@psharma-gdal I've notice odd formatting in your PR. Can you setup pre-commit as documented in https://gdal.org/en/stable/development/dev_practices.html#commit-hooks and force run it onto your files |
Formatting changes for ecw dynamic driver files using pre-commit hook
Update ECW Dynamic driver to build with ECW SDK version 6.0 or higher